Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1436943005: [turbofan] Add support for %_IsSpecObject intrinsic lowering. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for %_IsSpecObject intrinsic lowering. Now JSIntrinsicLowering can also lower %_IsSpecObject intrinsics to a diamond. R=mstarzinger@chromium.org Committed: https://crrev.com/c55161bf167ffc2e0936d7316580a7bebd76ed76 Cr-Commit-Position: refs/heads/master@{#31960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-12 13:32:10 UTC) #1
Benedikt Meurer
Hey Michi, Another trivial %_ intrinsic that we want to keep. Please take a look. ...
5 years, 1 month ago (2015-11-12 13:33:32 UTC) #2
Michael Starzinger
LGTM.
5 years, 1 month ago (2015-11-12 14:00:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436943005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436943005/1
5 years, 1 month ago (2015-11-12 14:01:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 14:05:41 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c55161bf167ffc2e0936d7316580a7bebd76ed76
Cr-Commit-Position: refs/heads/master@{#31960}

Powered by Google App Engine
This is Rietveld 408576698