Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1436943002: Implemented the RoundUint64ToFloat64 TurboFan operator for x64 and arm64. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implemented the RoundUint64ToFloat64 TurboFan operator for x64 and arm64. I don't see obvious implementations for mips64 and ppc64, so I would need help for these two platforms. R=titzer@chromium.org Committed: https://crrev.com/857cd4c1f0c24b8f38b0dcfe5cee5bb4407436ca Cr-Commit-Position: refs/heads/master@{#31946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -1 line) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahaas
5 years, 1 month ago (2015-11-11 16:39:27 UTC) #1
titzer
On 2015/11/11 16:39:27, ahaas wrote: lgtm
5 years, 1 month ago (2015-11-11 19:01:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436943002/1
5 years, 1 month ago (2015-11-11 19:11:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 19:12:31 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:11 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/857cd4c1f0c24b8f38b0dcfe5cee5bb4407436ca
Cr-Commit-Position: refs/heads/master@{#31946}

Powered by Google App Engine
This is Rietveld 408576698