cc: Refactor and cleanup RasterWorkerPool unit tests.

cc: Refactor and cleanup RasterWorkerPool unit tests.

Use parametrized tests to exercise all implementations of the
RasterWorkerPool interface.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247616

[reveman, 2014-01-27 04:58:57]

This is a follow up to my raster task refactor. Please take a look.

[alokp, 2014-01-27 08:09:19]

https://codereview.chromium.org/143693007/diff/1/cc/resources/raster_worker_p...
File cc/resources/raster_worker_pool_unittest.cc (right):

https://codereview.chromium.org/143693007/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool_unittest.cc:23: enum RasterThread { NONE,
ORIGIN, WORKER };
I prefer RASTER_THREAD prefix?

https://codereview.chromium.org/143693007/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool_unittest.cc:267: std::vector<unsigned>
completed_task_ids_;
It may be better to store a single vector of structs. Each struct will store id,
cancellation, and raster thread.

[reveman, 2014-01-27 16:03:20]

https://codereview.chromium.org/143693007/diff/1/cc/resources/raster_worker_p...
File cc/resources/raster_worker_pool_unittest.cc (right):

https://codereview.chromium.org/143693007/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool_unittest.cc:23: enum RasterThread { NONE,
ORIGIN, WORKER };
On 2014/01/27 08:09:19, Alok Priyadarshi wrote:
> I prefer RASTER_THREAD prefix?

Done.

https://codereview.chromium.org/143693007/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool_unittest.cc:267: std::vector<unsigned>
completed_task_ids_;
On 2014/01/27 08:09:19, Alok Priyadarshi wrote:
> It may be better to store a single vector of structs. Each struct will store
id,
> cancellation, and raster thread.

Done.

[vmpstr, 2014-01-28 19:19:51]

lgtm, assuming Alok is happy with it.

[commit-bot: I haz the power, 2014-01-28 23:52:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/143693007/60001

[commit-bot: I haz the power, 2014-01-29 05:02:52]

Change committed as 247616