Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 14369004: Allowing Chrome Dev. Adding README note on running Python tests on 64-bit OSX. (Closed)

Created:
7 years, 8 months ago by klm
Modified:
7 years, 8 months ago
CC:
chromium-reviews, klundberg1
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Allowing Chrome Dev. Adding README note on running Python tests on 64-bit OSX.

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/test/chromedriver/README.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/adb_commands.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
klm
7 years, 8 months ago (2013-04-19 18:23:41 UTC) #1
klundberg
Frank and Craig are the best persons to review this.
7 years, 8 months ago (2013-04-19 19:44:50 UTC) #2
kkania
REAMDE lgtm https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/README.txt File chrome/test/chromedriver/README.txt (right): https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/README.txt#newcode24 chrome/test/chromedriver/README.txt:24: necessary to run python as 'arch -i386 ...
7 years, 8 months ago (2013-04-19 20:39:40 UTC) #3
klm
https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/README.txt File chrome/test/chromedriver/README.txt (right): https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/README.txt#newcode24 chrome/test/chromedriver/README.txt:24: necessary to run python as 'arch -i386 python', because ...
7 years, 8 months ago (2013-04-19 20:49:42 UTC) #4
craigdh
lgtm.
7 years, 8 months ago (2013-04-19 21:56:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/1
7 years, 8 months ago (2013-04-19 22:01:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
7 years, 8 months ago (2013-04-19 23:19:20 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-19 23:26:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
7 years, 8 months ago (2013-04-20 00:22:30 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 02:01:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
7 years, 8 months ago (2013-04-20 02:27:43 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 02:43:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
7 years, 8 months ago (2013-04-20 03:03:34 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 03:14:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
7 years, 8 months ago (2013-04-20 03:24:43 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 03:40:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
7 years, 8 months ago (2013-04-20 03:51:26 UTC) #17
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 03:59:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
7 years, 8 months ago (2013-04-20 12:30:26 UTC) #19
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 12:40:04 UTC) #20
gavinp
Committed patchset #2 manually as r195394 (presubmit successful).
7 years, 8 months ago (2013-04-20 13:12:43 UTC) #21
klm
7 years, 8 months ago (2013-04-20 14:43:54 UTC) #22
Thanks Gavin, really appreciate it!

Michael
Sent from my mobile device

Powered by Google App Engine
This is Rietveld 408576698