|
|
DescriptionAllowing Chrome Dev. Adding README note on running Python tests on 64-bit OSX.
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 22 (0 generated)
Frank and Craig are the best persons to review this.
REAMDE lgtm https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/READ... File chrome/test/chromedriver/README.txt (right): https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/READ... chrome/test/chromedriver/README.txt:24: necessary to run python as 'arch -i386 python', because the 'chromedriver2.so' sometimes this may not be sufficient either; i forget why exactly, maybe because on some macs its just a symlink to the univeral python binary, and arch doesn't handle symlinks well; we've found just setting the env var VERSIONER_PYTHON_PREFER_32_BIT=yes to work best
https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/READ... File chrome/test/chromedriver/README.txt (right): https://codereview.chromium.org/14369004/diff/1/chrome/test/chromedriver/READ... chrome/test/chromedriver/README.txt:24: necessary to run python as 'arch -i386 python', because the 'chromedriver2.so' On 2013/04/19 20:39:40, kkania wrote: > sometimes this may not be sufficient either; i forget why exactly, maybe because > on some macs its just a symlink to the univeral python binary, and arch doesn't > handle symlinks well; we've found just setting the env var > VERSIONER_PYTHON_PREFER_32_BIT=yes to work best Thanks, confirmed working and adjusted the note.
lgtm.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
Step "update" is always a major failure. Look at the try server FAQ for more details. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
Sorry for I got bad news for ya. Compile failed with a clobber build on win7_aura. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
Sorry for I got bad news for ya. Compile failed with a clobber build on win7_aura. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
Sorry for I got bad news for ya. Compile failed with a clobber build on win7_aura. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
Sorry for I got bad news for ya. Compile failed with a clobber build on win7_aura. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
Sorry for I got bad news for ya. Compile failed with a clobber build on win7_aura. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14369004/7003
Sorry for I got bad news for ya. Compile failed with a clobber build on win7_aura. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
Message was sent while issue was closed.
Committed patchset #2 manually as r195394 (presubmit successful).
Thanks Gavin, really appreciate it! Michael Sent from my mobile device |