Issue 1436843003: Merge to XFA: Cleanup CPDF_ApSettings and CJS_Parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1436843003: Merge to XFA: Cleanup CPDF_ApSettings and CJS_Parameters. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Cleanup CPDF_ApSettings and CJS_Parameters. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1432863004 . (cherry picked from commit 56e3da27d8bed8a6c03274b7b946e3f6d6ac11f4) Committed: https://pdfium.googlesource.com/pdfium/+/dd734def34bc31be370b168267ccba9705c7fc1b

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -139 lines)			Patch
M	core/include/fpdfdoc/fpdf_doc.h	View	4 chunks	+41 lines, -44 lines	0 comments	Download
M	core/src/fpdfdoc/doc_form.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	core/src/fpdfdoc/doc_formcontrol.cpp	View	4 chunks	+62 lines, -79 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.h	View	1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-11-11 18:17:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dd734def34bc31be370b168267ccba9705c7fc1b (presubmit successful).