pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart - Issue 1436833002: dart2js cps: Do not propagate expressions into foreign code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 1436833002: dart2js cps: Do not propagate expressions into foreign code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add TODO regarding capture of this Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

index cd688d51ca51e9b5a202130e1f84f9b2f135dc94..bd4baabdded66a78f6c58b845781d5f5b292032c 100644

--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

@@ -119,10 +119,8 @@ class Variable extends Node {

/// - catch parameter in a [Try]

int writeCount = 0;

- /// True if a nested function reads or writes this variable.

- ///

- /// Always false in JS-mode because closure conversion eliminated nested

- /// functions.

+ /// True if an inner JS function might access this variable through a

+ /// [ForeignCode] node.

bool isCaptured = false;

Variable(this.host, this.element) {