Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/common/pref_names.cc

Issue 143683004: Add UMA to track app launcher discoverability. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/pref_names.cc
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index eb49ed045061ace9fd0430350b8e743e4073c728..a681f8ce6ff04f533ad3aa6c9a997607f764e609 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -2560,7 +2560,7 @@ const char kRLZDisabled[] = "rlz.disabled";
#if defined(ENABLE_APP_LIST)
// The directory in user data dir that contains the profile to be used with the
// app launcher.
-extern const char kAppListProfile[] = "app_list.profile";
+const char kAppListProfile[] = "app_list.profile";
// Whether to show the app list on a browser relaunch. Used when switching out
// of metro mode after a user gesture requests showing the app list.
@@ -2568,18 +2568,25 @@ const char kRestartWithAppList[] = "app_list.show_on_relaunch";
// The number of times the app launcher was launched since last ping and
// the time of the last ping.
-extern const char kAppListLaunchCount[] = "app_list.launch_count";
-extern const char kLastAppListLaunchPing[] = "app_list.last_launch_ping";
+const char kAppListLaunchCount[] = "app_list.launch_count";
+const char kLastAppListLaunchPing[] = "app_list.last_launch_ping";
// The number of times the an app was launched from the app launcher since last
// ping and the time of the last ping.
-extern const char kAppListAppLaunchCount[] = "app_list.app_launch_count";
-extern const char kLastAppListAppLaunchPing[] = "app_list.last_app_launch_ping";
+const char kAppListAppLaunchCount[] = "app_list.app_launch_count";
+const char kLastAppListAppLaunchPing[] = "app_list.last_app_launch_ping";
// A boolean that tracks whether the user has ever enabled the app launcher.
const char kAppLauncherHasBeenEnabled[] =
"apps.app_launcher.has_been_enabled";
+// An enum indicating how the app launcher was enabled. E.g., via webstore, app
+// install, command line, etc. For UMA.
+const char kAppListEnableMethod[] = "app_list.how_enabled";
+
+// The time that the app launcher was enabled. Cleared when UMA is recorded.
+const char kAppListEnableTime[] = "app_list.when_enabled";
+
// TODO(calamity): remove this pref since app launcher will always be
// installed.
// Local state caching knowledge of whether the app launcher is installed.
« chrome/browser/ui/app_list/app_list_service_impl.cc ('K') | « chrome/common/pref_names.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698