content/browser/renderer_host/render_widget_host_view_android.h - Issue 143683003: Support format using enum argument for Async readback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 143683003: Support format using enum argument for Async readback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code changes as per review. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index dc7a77f414bdf56488e095f73879f34134ac89a2..091f2a9e3c40df2a29bb947b9d92e0fcdd107f98 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -139,7 +139,7 @@ class RenderWidgetHostViewAndroid

const gfx::Rect& src_subrect,

const gfx::Size& dst_size,

const base::Callback<void(bool, const SkBitmap&)>& callback,

- bool readback_config_rgb565) OVERRIDE;

+ const SkBitmap::Config config) OVERRIDE;

virtual void CopyFromCompositingSurfaceToVideoFrame(

const gfx::Rect& src_subrect,

const scoped_refptr<media::VideoFrame>& target,

@@ -274,7 +274,7 @@ class RenderWidgetHostViewAndroid

// of the copy.

static void PrepareTextureCopyOutputResult(

const gfx::Size& dst_size_in_pixel,

- bool readback_config_rgb565,

+ const SkBitmap::Config config,

const base::TimeTicks& start_time,

const base::Callback<void(bool, const SkBitmap&)>& callback,

scoped_ptr<cc::CopyOutputResult> result);