content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 143683003: Support format using enum argument for Async readback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 143683003: Support format using enum argument for Async readback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace bool with enum to support other formats Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_gtk.cc ('K') | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/common/gpu/client/gl_helper.h » ('j') | content/common/gpu/client/gl_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 3b68caf048017dbeaa47060de9dec4bde6747114..5208c50630178857eff052e4910bfdc2f13767f4 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1135,8 +1135,8 @@ void RenderWidgetHostViewMac::CopyFromCompositingSurface(

const gfx::Rect& src_subrect,

const gfx::Size& dst_size,

const base::Callback<void(bool, const SkBitmap&)>& callback,

- bool readback_config_rgb565) {

- if (readback_config_rgb565) {

+ const SkBitmap::Config config) {

+ if (config == SkBitmap::kRGB_565_Config) {

piman 2014/01/21 21:30:55 nit: config != SkBitmap::kARGB_8888_Config

sivag 2014/01/22 10:35:09 Done.

NOTIMPLEMENTED();

callback.Run(false, SkBitmap());

}