Issue 1436813002: Fix Array.prototype.slice with arguments object with negative length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1436813002: Fix Array.prototype.slice with arguments object with negative length. (Closed)

Created:
5 years, 1 month ago by Toon Verwaest

Modified:
5 years, 1 month ago

Reviewers:
Camillo Bruni

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix Array.prototype.slice with arguments object with negative length. BUG= Committed: https://crrev.com/2ebd5fc7c934ec0a07c3ef0958b7fee35fa2e974 Cr-Commit-Position: refs/heads/master@{#31941}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
	M	src/builtins.cc	View		2 chunks	+7 lines, -11 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-arguments-slice.js	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436813002/1

5 years, 1 month ago (2015-11-11 11:33:21 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-11 11:50:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2ebd5fc7c934ec0a07c3ef0958b7fee35fa2e974
Cr-Commit-Position: refs/heads/master@{#31941}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages