chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java - Issue 1436743002: Integrate new Reader Mode panel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Issue 1436743002: Integrate new Reader Mode panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scene-layer-changes

Patch Set: findbugs and low-end devices Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerTest.java ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

index 8fbe2963417602128861a89089dacea433a7eea5..78e8c44bae85454c677247e1bf45bbbac62c56f7 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

@@ -749,12 +749,12 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro

// TODO(pedrosimonetti): This is not reliable. Find a better approach.

// We use the far right side (x == 0.9f) to prevent simulating a tap on top of an

// existing long-press selection (the pins are a tap target). This might not work on RTL.

- // We are using y == 0.2f because otherwise it will fail for long press cases.

+ // We are using y == 0.35f because otherwise it will fail for long press cases.

// It might be better to get the position of the Panel and tap just about outside

// the Panel. I suspect some Flaky tests are caused by this problem (ones involving

// long press and trying to close with the bar peeking, with a long press selection

// established).

- tapBasePage(0.9f, 0.2f);

+ tapBasePage(0.9f, 0.35f);

waitForPanelToCloseAndAssert();

}