Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6236)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1436743002: Integrate new Reader Mode panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scene-layer-changes
Patch Set: findbugs and low-end devices Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index c4051e13f4037e7c6a7b9644bd9722cd142f46d8..b8ba4640883ab4c849238fce71efaf464d6adc03 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -75,7 +75,6 @@ import org.chromium.chrome.browser.contextualsearch.ContextualSearchManager.Cont
import org.chromium.chrome.browser.datausage.DataUseTabUIManager;
import org.chromium.chrome.browser.device.DeviceClassManager;
import org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsView;
-import org.chromium.chrome.browser.dom_distiller.ReaderModeActivityDelegate;
import org.chromium.chrome.browser.dom_distiller.ReaderModeManager;
import org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkUtils;
import org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarksModel;
@@ -208,7 +207,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
private ChromeFullscreenManager mFullscreenManager;
private CompositorViewHolder mCompositorViewHolder;
private ContextualSearchManager mContextualSearchManager;
- private ReaderModeActivityDelegate mReaderModeActivityDelegate;
+ private ReaderModeManager mReaderModeManager;
private SnackbarManager mSnackbarManager;
private LoFiBarPopupController mLoFiBarPopupController;
private DataUseSnackbarController mDataUseSnackbarController;
@@ -447,7 +446,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
}
if (ReaderModeManager.isEnabled(this)) {
- mReaderModeActivityDelegate = new ReaderModeActivityDelegate(this);
+ mReaderModeManager = new ReaderModeManager(getTabModelSelector(), this);
}
TraceEvent.end("ChromeActivity:CompositorInitialization");
@@ -753,9 +752,9 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
@SuppressLint("NewApi")
@Override
protected final void onDestroy() {
- if (mReaderModeActivityDelegate != null) {
- mReaderModeActivityDelegate.destroy();
- mReaderModeActivityDelegate = null;
+ if (mReaderModeManager != null) {
+ mReaderModeManager.destroy();
+ mReaderModeManager = null;
}
if (mContextualSearchManager != null) {
@@ -1200,14 +1199,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
}
/**
- * @return A {@link ReaderModeActivityDelegate} instance or {@code null} if reader mode is
- * not enabled.
- */
- public ReaderModeActivityDelegate getReaderModeActivityDelegate() {
- return mReaderModeActivityDelegate;
- }
-
- /**
* Create a full-screen manager to be used by this activity.
* @param controlContainer The control container that will be controlled by the full-screen
* manager.
@@ -1259,12 +1250,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
mContextualSearchManager.setSearchContentViewDelegate(layoutManager);
}
- if (mReaderModeActivityDelegate != null) {
- mReaderModeActivityDelegate.initialize(contentContainer);
- mReaderModeActivityDelegate.setDynamicResourceLoader(
- mCompositorViewHolder.getDynamicResourceLoader());
- }
-
layoutManager.addSceneChangeObserver(this);
mCompositorViewHolder.setLayoutManager(layoutManager);
mCompositorViewHolder.setFocusable(false);
@@ -1272,7 +1257,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
mCompositorViewHolder.setFullscreenHandler(mFullscreenManager);
mCompositorViewHolder.setUrlBar(urlBar);
mCompositorViewHolder.onFinishNativeInitialization(getTabModelSelector(), this,
- getTabContentManager(), contentContainer, mContextualSearchManager);
+ getTabContentManager(), contentContainer, mContextualSearchManager,
+ mReaderModeManager);
if (controlContainer != null
&& DeviceClassManager.enableToolbarSwipe(FeatureUtilities.isDocumentMode(this))) {
@@ -1289,7 +1275,10 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
@Override
public void onOrientationChange(int orientation) {
+ // TODO(mdjones): Orientation change for panels should not be handled here. The event
+ // should probably be passed to the OverlayPanelManager.
if (mContextualSearchManager != null) mContextualSearchManager.onOrientationChange();
+ if (mReaderModeManager != null) mReaderModeManager.onOrientationChange();
if (mToolbarManager != null) mToolbarManager.onOrientationChange();
}

Powered by Google App Engine
This is Rietveld 408576698