Issue 143673005: Remove Entity interface

Issue 143673005: Remove Entity interface (Closed)

Created:
6 years, 10 months ago by silverroots

Modified:
6 years, 10 months ago

Reviewers:
abarth-chromium, dglazkov, Inactive

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove Entity interface Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/k3tZGP2EANc BUG=338602 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165953

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -117 lines)			Patch
M	LayoutTests/fast/dom/Window/get-set-properties.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/Window/get-set-properties-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/resources/window-properties.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/window-property-shadowing.html	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/dom-constructors.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/dom-constructors-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-get.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-get-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-put.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/cross-frame-access-put-expected.txt	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/idls/TestObjectPython.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View	3 chunks	+0 lines, -29 lines	0 comments	Download
M	Source/bindings/v8/custom/V8NodeCustom.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/core.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	Source/core/dom/Entity.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	Source/core/dom/Entity.idl	View	1 chunk	+0 lines, -25 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

silverroots

Hi, Can you please review my patch for removing entity interface?

6 years, 10 months ago (2014-01-28 11:02:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaustubh.a@samsung.com/143673005/1

6 years, 10 months ago (2014-01-28 16:45:07 UTC) #4

Message was sent while issue was closed.

Change committed as 165953

Expand Messages | Collapse Messages