Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 14367047: Some more cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/templates/immutable_list_mixin.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index 06c2cc6d4d20b7b3698eff5065615f60ed96d478..8c2699269c03a01b0eaebc69855a67e0cf6e5464 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -320,10 +320,7 @@ class HtmlDartGenerator(object):
def AdditionalImplementedInterfaces(self):
# TODO: Include all implemented interfaces, including other Lists.
implements = []
- if self._interface_type_info.is_typed_array():
- element_type = self._interface_type_info.list_item_type()
- implements.append('List<%s>' % element_type)
- elif self._interface_type_info.list_item_type():
+ if self._interface_type_info.list_item_type():
item_type_info = self._type_registry.TypeInfo(
self._interface_type_info.list_item_type())
implements.append('List<%s>' % item_type_info.dart_type())
@@ -343,41 +340,6 @@ class HtmlDartGenerator(object):
self._AddConstructor(
constructor_info, factory_name, factory_constructor_name)
- typed_array_type = None
- for interface in self._database.Hierarchy(self._interface):
- type_info = self._type_registry.TypeInfo(interface.id)
- if type_info.is_typed_array():
- typed_array_type = type_info.list_item_type()
- break
-
- annotations = FormatAnnotationsAndComments(
- GetAnnotationsAndComments(self._library_name, self._interface.id,
- self._interface.id), ' ')
-
- fromListAnnotations = FormatAnnotationsAndComments(
- GetAnnotationsAndComments(self._library_name, self._interface.id,
- 'fromList'), ' ')
-
- fromBufferAnnotations = FormatAnnotationsAndComments(
- GetAnnotationsAndComments(self._library_name, self._interface.id,
- 'fromBuffer'), ' ')
-
- if typed_array_type:
- self._members_emitter.Emit(
- '\n $(ANNOTATIONS)factory $CTOR(int length) =>\n'
- ' $FACTORY.create$(CTOR)(length);\n'
- '\n $(LIST_ANNOTATIONS)factory $CTOR.fromList(List<$TYPE> list) =>\n'
- ' $FACTORY.create$(CTOR)_fromList(list);\n'
- '\n $(BUFFER_ANNOTATIONS)factory $CTOR.view(ByteBuffer buffer, '
- '[int byteOffset, int length]) => \n'
- ' $FACTORY.create$(CTOR)_fromBuffer(buffer, byteOffset, length);\n',
- CTOR=self._renamer.RenameInterface(interface),
- ANNOTATIONS=annotations,
- LIST_ANNOTATIONS=fromListAnnotations,
- BUFFER_ANNOTATIONS=fromBufferAnnotations,
- TYPE=self._DartType(typed_array_type),
- FACTORY=factory_name)
-
def _AddConstructor(self,
constructor_info, factory_name, factory_constructor_name):
if self.GenerateCustomFactory(constructor_info):
@@ -567,7 +529,6 @@ class HtmlDartGenerator(object):
has_clear = any(op.id == 'clear' for op in self._interface.operations)
has_length = False
has_length_setter = False
- typed_array = self._interface_type_info.is_typed_array()
for attr in self._interface.attributes:
if attr.id == 'length':
@@ -582,7 +543,6 @@ class HtmlDartGenerator(object):
{
'DEFINE_CONTAINS': not has_contains,
'DEFINE_CLEAR': not has_clear,
- 'DEFINE_IMMUTABLE': not typed_array,
'DEFINE_LENGTH_AS_NUM_ITEMS': not has_length and has_num_items,
'DEFINE_LENGTH_SETTER': not has_length_setter,
})
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/templates/immutable_list_mixin.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698