Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1436703002: Revert of [Presentation API / Media Router] Clean up default pres URL logic. (Closed)

Created:
5 years, 1 month ago by robliao
Modified:
5 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, media-router+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Presentation API / Media Router] Clean up default pres URL logic. (patchset #16 id:300001 of https://codereview.chromium.org/1406013003/ ) Reason for revert: Prime suspect in causing mojo_runner_unittests mojo_runner_unittests failures: BackgroundApplicationLoaderTest.Load NativeApplicationLoaderTest.DoesNotExist https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/32013 Original issue's description: > [Presentation API / Media Router] Clean up default pres URL logic. > > 1. In presentation_service.mojom, there were 2 methods for default > presentation: ListenForDefaultSessionStart and SetDefaultPresentationURL. > There is no reason they should be called separately. Furthermore, > ListenForDefaultSessionStart is called after connecting to > PresentationService, which is not optimal. This CL removes the former > method. > > 2. Remove OnDefaultSessionStarted from PSD::Observer and replace it > with callbacks. The purpose of PSD::Observer is to notify > PresentationServiceImpl that PresentationServiceDelegate is being > destroyed and shouldn't include specific Pres API logic. > > 3. Fix default request matching logic in PSDImpl to account for all > of (frame, frame url, presentation url). Previously it was only > checking presentation url and always assumes it came from the > current main frame. This is a problem because the main frame of a > WebContents can change over time, i.e. main frame at time of setting > DPU and time of route response could be different). Now we create > a PresentationRequest object to hold all info needed to match default > request and pass it to MRUI, who then binds the request to the route > response callback in PSDImpl/PresentationFrameManager to perform the > matching. > > BUG=544259 > > Committed: https://crrev.com/6104fb062821e3e8584ed2e40cdb3f77502d88f0 > Cr-Commit-Position: refs/heads/master@{#358935} TBR=mfoltz@chromium.org,avayvod@chromium.org,mlamouri@chromium.org,imcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=544259 Committed: https://crrev.com/8ed7e286df82468f631e3788155ff0a517f80af9 Cr-Commit-Position: refs/heads/master@{#359007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+811 lines, -975 lines) Patch
M chrome/browser/media/android/router/media_router_dialog_controller_android.cc View 5 chunks +14 lines, -15 lines 0 comments Download
D chrome/browser/media/router/create_presentation_connection_request.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/media/router/create_presentation_connection_request.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/media/router/create_presentation_connection_request_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
A chrome/browser/media/router/create_presentation_session_request.h View 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/browser/media/router/create_presentation_session_request.cc View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/media/router/create_presentation_session_request_unittest.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router.gypi View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/media/router/media_router_dialog_controller.h View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/media/router/media_router_dialog_controller.cc View 2 chunks +6 lines, -6 lines 0 comments Download
D chrome/browser/media/router/presentation_request.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/media/router/presentation_request.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/media/router/presentation_request_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.h View 6 chunks +77 lines, -75 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 20 chunks +90 lines, -179 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 7 chunks +56 lines, -129 lines 0 comments Download
D chrome/browser/media/router/render_frame_host_id.h View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.h View 4 chunks +21 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 8 chunks +52 lines, -63 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 5 chunks +28 lines, -6 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 5 chunks +57 lines, -9 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 7 chunks +103 lines, -35 lines 0 comments Download
M content/common/presentation/presentation_service.mojom View 4 chunks +13 lines, -13 lines 0 comments Download
M content/public/browser/presentation_service_delegate.h View 5 chunks +16 lines, -12 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robliao
Created Revert of [Presentation API / Media Router] Clean up default pres URL logic.
5 years, 1 month ago (2015-11-11 01:29:15 UTC) #1
imcheng
lgtm
5 years, 1 month ago (2015-11-11 01:34:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436703002/1
5 years, 1 month ago (2015-11-11 01:35:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 01:40:00 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 01:40:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ed7e286df82468f631e3788155ff0a517f80af9
Cr-Commit-Position: refs/heads/master@{#359007}

Powered by Google App Engine
This is Rietveld 408576698