Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8121)

Unified Diff: chrome/browser/signin/signin_manager_base.cc

Issue 14367029: Introduce SigninManagerDelegate and use to eliminate CookieSettings dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_manager_base.h ('k') | chrome/browser/signin/signin_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager_base.cc
diff --git a/chrome/browser/signin/signin_manager_base.cc b/chrome/browser/signin/signin_manager_base.cc
index 0433e447c5840c236fe3edcfbcc1ab8743c3f428..980a1fd4cc09d4cbed8d42d62083d57f0a10b67a 100644
--- a/chrome/browser/signin/signin_manager_base.cc
+++ b/chrome/browser/signin/signin_manager_base.cc
@@ -14,7 +14,6 @@
#include "base/strings/string_split.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
-#include "chrome/browser/content_settings/cookie_settings.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_io_data.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -40,22 +39,6 @@ using namespace signin_internals_util;
using content::BrowserThread;
// static
-bool SigninManagerBase::AreSigninCookiesAllowed(Profile* profile) {
- CookieSettings* cookie_settings =
- CookieSettings::Factory::GetForProfile(profile);
- return AreSigninCookiesAllowed(cookie_settings);
-}
-
-// static
-bool SigninManagerBase::AreSigninCookiesAllowed(
- CookieSettings* cookie_settings) {
- return cookie_settings &&
- cookie_settings->IsSettingCookieAllowed(
- GURL(GaiaUrls::GetInstance()->gaia_origin_url()),
- GURL(GaiaUrls::GetInstance()->gaia_origin_url()));
-}
-
-// static
bool SigninManagerBase::IsAllowedUsername(const std::string& username,
const std::string& policy) {
if (policy.empty())
« no previous file with comments | « chrome/browser/signin/signin_manager_base.h ('k') | chrome/browser/signin/signin_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698