Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 14367023: Refactor HCheckMaps to have a private constructor, removing duplicated code and simplifying calls i… (Closed)

Created:
7 years, 8 months ago by titzer
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Refactor HCheckMaps to have a private constructor, removing duplicated code and simplifying calls in clients. Ignore bsuite directory. Committed: https://code.google.com/p/v8/source/detail?r=14362

Patch Set 1 #

Total comments: 1

Patch Set 2 : Alphabetize gitignore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -40 lines) Patch
M .gitignore View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 9 chunks +9 lines, -10 lines 0 comments Download
M src/hydrogen-instructions.h View 1 3 chunks +31 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
titzer
7 years, 8 months ago (2013-04-19 16:05:14 UTC) #1
titzer
I'm not sure why/how my .gitignore ended up in this CL, but I can remove ...
7 years, 8 months ago (2013-04-19 16:06:35 UTC) #2
titzer
7 years, 8 months ago (2013-04-19 16:06:45 UTC) #3
Michael Starzinger
LGTM (with a nit). https://codereview.chromium.org/14367023/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/14367023/diff/1/.gitignore#newcode26 .gitignore:26: bsuite nit: I don't have ...
7 years, 8 months ago (2013-04-19 16:16:15 UTC) #4
titzer
On 2013/04/19 16:16:15, Michael Starzinger wrote: > LGTM (with a nit). > > https://codereview.chromium.org/14367023/diff/1/.gitignore > ...
7 years, 8 months ago (2013-04-19 16:37:25 UTC) #5
titzer
7 years, 8 months ago (2013-04-19 16:46:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r14362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698