Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 14367012: Move to new dart:typeddata types for dart2js (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revert generated files for html lib Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/systemhtml.py
diff --git a/tools/dom/scripts/systemhtml.py b/tools/dom/scripts/systemhtml.py
index b36ddcb4a1810d47e961c9d75c464a69b21c612c..5454ba98c0c204b2827159feeea4b69478c4a522 100644
--- a/tools/dom/scripts/systemhtml.py
+++ b/tools/dom/scripts/systemhtml.py
@@ -12,11 +12,10 @@ import os
from generator import *
from htmldartgenerator import *
-HTML_LIBRARY_NAMES = ['chrome', 'html', 'indexed_db', 'svg', 'web_audio',
- 'web_gl', 'web_sql']
+HTML_LIBRARY_NAMES = ['chrome', 'html', 'indexed_db', 'svg',
+ 'web_audio', 'web_gl', 'web_sql']
_js_custom_members = monitored.Set('systemhtml._js_custom_members', [
- 'ArrayBuffer.slice',
'AudioBufferSourceNode.start',
'AudioBufferSourceNode.stop',
'AudioContext.createGain',
@@ -264,6 +263,7 @@ _element_constructors = {
'html': _html_element_constructors,
'indexed_db': {},
'svg': _svg_element_constructors,
+ 'typeddata': {},
'web_audio': {},
'web_gl': {},
'web_sql': {},
@@ -282,6 +282,10 @@ _factory_ctr_strings = {
'provider_name': '_SvgElementFactoryProvider',
'constructor_name': 'createSvgElement_tag',
},
+ 'typeddata': {
+ 'provider_name': 'document',
+ 'constructor_name': '$dom_createElement'
+ },
'web_audio': {
'provider_name': 'document',
'constructor_name': '$dom_createElement'
@@ -424,7 +428,9 @@ class HtmlDartInterfaceGenerator(object):
self._library_name = self._renamer.GetLibraryName(self._interface)
def Generate(self):
- if 'Callback' in self._interface.ext_attrs:
+ if IsCustomType(self._interface.id):
+ pass
+ elif 'Callback' in self._interface.ext_attrs:
self.GenerateCallback()
else:
self.GenerateInterface()

Powered by Google App Engine
This is Rietveld 408576698