Fix Javascript errors occuring when a file is deleted during calculating it's size.

chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Expected files before tests are performed. Entries for Local tests.
  * @type {Array.<Array.<string>>}
  * @const
  */
 var EXPECTED_FILES_BEFORE_LOCAL = [
@@ skipping 46 matching lines @@
  */
 function setupAndWaitUntilReady(path, callback) {
   callRemoteTestUtil('openMainWindow', null, [path], function(appId) {
     callRemoteTestUtil('waitForFileListChange', appId, [0], function(files) {
       callback(appId, files);
     });
   });
 }
 
 /**
+ * Verifies if there are no Javascript errors in any of the app windows.
+ * @param {function()} Completion callback.
+ */
+function checkIfNoErrorsOccured(callback) {
+  callRemoteTestUtil('getErrorCount', null, [], function(count) {
+    chrome.test.assertEq(0, count);
+    callback();
+  });
+}
+
+/**
  * Expected files shown in "Recent". Directories (e.g. 'photos') are not in this
  * list as they are not expected in "Recent".
+ *
  * @type {Array.<Array.<string>>}
  * @const
  */
 var EXPECTED_FILES_IN_RECENT = [
   ['hello.txt', '123 bytes', 'Plain text', 'Sep 4, 1998 12:34 PM'],
   ['world.mpeg', '1,000 bytes', 'MPEG video', 'Jul 4, 2012 10:35 AM'],
   ['My Desktop Background.png', '1 KB', 'PNG image', 'Jan 18, 2038 1:02 AM'],
   ['Test Document.gdoc','--','Google document','Apr 10, 2013 4:20 PM'],
 ].sort();
 
@@ skipping 29 matching lines @@
   var expectedFilesAfter =
       expectedFilesBefore.concat(EXPECTED_NEWLY_ADDED_FILE).sort();
 
   setupAndWaitUntilReady(path, function(appId, actualFilesBefore) {
     chrome.test.assertEq(expectedFilesBefore, actualFilesBefore);
     chrome.test.sendMessage('initial check done', function(reply) {
       chrome.test.assertEq('file added', reply);
       callRemoteTestUtil(
           'waitForFileListChange',
           appId,
-          [expectedFilesBefore.length],
-          chrome.test.callbackPass(function(actualFilesAfter) {
+          [expectedFilesBefore.length], function(actualFilesAfter) {
             chrome.test.assertEq(expectedFilesAfter, actualFilesAfter);
-          }));
+            checkIfNoErrorsOccured(chrome.test.succeed);
+          });
     });
   });
 };
 
 /**
  * Tests copying a file to the same directory and waits until the file lists
  * changes.
  *
  * @param {string} path Directory path to be tested.
  */
-testcase.intermediate.keyboardCopy = function(path) {
+testcase.intermediate.keyboardCopy = function(path, callback) {
   setupAndWaitUntilReady(path, function(appId) {
     callRemoteTestUtil('copyFile', appId, ['world.mpeg'], function(result) {
       chrome.test.assertFalse(!result);
       callRemoteTestUtil('waitForFileListChange',
                          appId,
                          [getExpectedFilesBefore(path == '/drive/root').length],
-                         chrome.test.succeed);
+                         checkIfNoErrorsOccured.bind(null,
+                                                     chrome.test.succeed));
     });
   });
 };
 
 /**
  * Tests deleting a file and and waits until the file lists changes.
  * @param {string} path Directory path to be tested.
  */
 testcase.intermediate.keyboardDelete = function(path) {
   setupAndWaitUntilReady(path, function(appId) {
     callRemoteTestUtil('deleteFile', appId, ['world.mpeg'], function(result) {
       chrome.test.assertFalse(!result);
       callRemoteTestUtil('waitAndAcceptDialog', appId, [], function() {
         callRemoteTestUtil(
             'waitForFileListChange',
             appId,
             [getExpectedFilesBefore(path == '/drive/root').length],
-            chrome.test.succeed);
+            checkIfNoErrorsOccured.bind(null, chrome.test.succeed));
       });
     });
   });
 };
 
 testcase.fileDisplayDownloads = function() {
   testcase.intermediate.fileDisplay('/Downloads');
 };
 
 testcase.keyboardCopyDownloads = function() {
@@ skipping 16 matching lines @@
   testcase.intermediate.keyboardDelete('/drive/root');
 };
 
 /**
  * Tests opening the "Recent" on the sidebar navigation by clicking the icon,
  * and verifies the directory contents. We test if there are only files, since
  * directories are not allowed in "Recent". This test is only available for
  * Drive.
  */
 testcase.openSidebarRecent = function() {
-  var onFileListChange = chrome.test.callbackPass(function(actualFilesAfter) {
+  var onFileListChange = function(actualFilesAfter) {
     chrome.test.assertEq(EXPECTED_FILES_IN_RECENT, actualFilesAfter);
-  });
+    checkIfNoErrorsOccured(chrome.test.succeed);
+  };
 
   setupAndWaitUntilReady('/drive/root', function(appId) {
     // Use the icon for a click target.
     callRemoteTestUtil(
         'fakeMouseClick', appId, ['[volume-type-icon=drive_recent]'],
         function(result) {
           chrome.test.assertFalse(!result);
           callRemoteTestUtil(
               'waitForFileListChange',
               appId,
               [getExpectedFilesBefore(true /* isDrive */).length],
               onFileListChange);
         });
   });
 };
 
 /**
  * Tests opening the "Offline" on the sidebar navigation by clicking the icon,
  * and checks contenets of the file list. Only the entries "available offline"
  * should be shown. "Available offline" entires are hosted documents and the
  * entries cached by DriveCache.
  */
 testcase.openSidebarOffline = function() {
-  var onFileListChange = chrome.test.callbackPass(function(actualFilesAfter) {
+  var onFileListChange = function(actualFilesAfter) {
     chrome.test.assertEq(EXPECTED_FILES_IN_OFFLINE, actualFilesAfter);
-  });
+    checkIfNoErrorsOccured(chrome.test.succeed);
+  };
 
   setupAndWaitUntilReady('/drive/root/', function(appId) {
     // Use the icon for a click target.
     callRemoteTestUtil(
         'fakeMouseClick', appId, ['[volume-type-icon=drive_offline]'],
         function(result) {
           chrome.test.assertFalse(!result);
           callRemoteTestUtil(
               'waitForFileListChange',
               appId,
               [getExpectedFilesBefore(true /* isDrive */).length],
               onFileListChange);
         });
   });
 };
 
 /**
  * Tests autocomplete with a query 'hello'. This test is only available for
  * Drive.
  */
 testcase.autocomplete = function() {
   var EXPECTED_AUTOCOMPLETE_LIST = [
     '\'hello\' - search Drive\n',
     'hello.txt\n',
   ];
 
-  var onAutocompleteListShown = chrome.test.callbackPass(
-      function(autocompleteList) {
-        chrome.test.assertEq(EXPECTED_AUTOCOMPLETE_LIST, autocompleteList);
-      });
+  var onAutocompleteListShown = function(autocompleteList) {
+    chrome.test.assertEq(EXPECTED_AUTOCOMPLETE_LIST, autocompleteList);
+    checkIfNoErrorsOccured(chrome.test.succeed);
+  };
 
   setupAndWaitUntilReady('/drive/root', function(appId, list) {
     callRemoteTestUtil('performAutocompleteAndWait',
                        appId,
                        ['hello', EXPECTED_AUTOCOMPLETE_LIST.length],
                        onAutocompleteListShown);
   });
 };