Fix Javascript errors occuring when a file is deleted during calculating it's size.

Fix Javascript errors occuring when a file is deleted during calculating it's size.

These errors occur when deleting very quickly, just after selecting a file. Such situation happens especially in tests. Along the way fixed the cancellation code.

TEST=Run browser_tests --test_filter="*FileManagerBrowser*Delete*"
BUG=233460
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195203

[mtomasz, 2013-04-19 05:15:21]

@satorux: PTAL.

[satorux1, 2013-04-19 07:52:18]

I like this idea! LGTM with nits

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_selection.js (right):

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:16:
this.sequenceIndex_ = 0;
sequenceIndex_ may sound too general as this is only used for computeBytes().
Maybe:

computeBytesSequence_

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:106: var onProps =
function(filesystem) {
The parameter looks like a misnomer. We are getting properties of a file, right?

Maybe |filesystem| -> properties

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:141:
this.sequenceIndex_++;
Maybe add some comment?

This will invalidate the sequence number used in the inflight computeBytes()
operation, hence cancel the operation.

[mtomasz, 2013-04-19 09:13:16]

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_selection.js (right):

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:16:
this.sequenceIndex_ = 0;
On 2013/04/19 07:52:18, satorux1 wrote:
> sequenceIndex_ may sound too general as this is only used for computeBytes().
> Maybe:
> 
> computeBytesSequence_

Done.

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:106: var onProps =
function(filesystem) {
On 2013/04/19 07:52:18, satorux1 wrote:
> The parameter looks like a misnomer. We are getting properties of a file,
right?
> 
> Maybe |filesystem| -> properties

This fetches the 'filesystem' metadata. Done.

https://codereview.chromium.org/14367009/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:141:
this.sequenceIndex_++;
On 2013/04/19 07:52:18, satorux1 wrote:
> Maybe add some comment?
> 
> This will invalidate the sequence number used in the inflight computeBytes()
> operation, hence cancel the operation.

Done.

[commit-bot: I haz the power, 2013-04-19 09:13:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14367009/8001

[mtomasz, 2013-04-19 15:09:25]

Committed patchset #3 manually as r195203 (presubmit successful).