Fix unit test leak in DeviceOAuth2TokenServiceTest.

chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_oauth2_token_service.h"
 
 #include "base/message_loop.h"
 #include "base/prefs/testing_pref_service.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/mock_cert_library.h"
@@ skipping 43 matching lines @@
       .Times(1)
       .WillOnce(Return(""));
   EXPECT_CALL(mock_cert_library, EncryptWithSystemSalt(StrEq("test-token")))
       .Times(1)
       .WillOnce(Return("encrypted"));
   EXPECT_CALL(mock_cert_library, DecryptWithSystemSalt(StrEq("encrypted")))
       .Times(1)
       .WillOnce(Return("test-token"));
 
   DeviceOAuth2TokenService oauth2_service(
-      new net::TestURLRequestContextGetter(
-          content::BrowserThread::GetMessageLoopProxyForThread(
-              content::BrowserThread::IO)),
+      new net::TestURLRequestContextGetter(message_loop_.message_loop_proxy()),

[Mattias Nissler (ping if slow), 2013/04/19 17:45:19]

I don't see how this fixes the problem, can you enlighten me?

[David Roche, 2013/04/19 22:05:03]

So, the key is in URLRequestContextGetter::OnDestruct().  If it has a task
runner on the current thread it will immediately 'delete this', but if the task
runner is on a diff thread, then it will

  network_task_runner->DeleteSoon(FROM_HERE, this)

which would only run if my test called RunUntilIdle() on that task runner, which
it wasn't.

However, since this test isn't even using the URLRequestContextGetter anyway
(it's just needed to pass a DCHECK), it was simpler to just give it a task
runner from the current message loop and thereby trigger an immediate delete.

       scoped_testing_local_state_.Get());
 
   ASSERT_EQ("", oauth2_service.GetRefreshToken());
   oauth2_service.SetAndSaveRefreshToken("test-token");
   ASSERT_EQ("test-token", oauth2_service.GetRefreshToken());
 
   // This call won't invoke decrypt again, since the value is cached.
   ASSERT_EQ("test-token", oauth2_service.GetRefreshToken());
 }
 
 }  // namespace chromeos