Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 14367003: MIPS: HArgument instructions currently require a frame. In Lithium we can ensure a frame is created… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 966 matching lines...) Expand 10 before | Expand all | Expand 10 after
977 977
978 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) { 978 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) {
979 ASSERT(instr->value()->representation().IsTagged()); 979 ASSERT(instr->value()->representation().IsTagged());
980 LOperand* value = UseRegisterAtStart(instr->value()); 980 LOperand* value = UseRegisterAtStart(instr->value());
981 LOperand* temp = TempRegister(); 981 LOperand* temp = TempRegister();
982 return new(zone()) LCmpMapAndBranch(value, temp); 982 return new(zone()) LCmpMapAndBranch(value, temp);
983 } 983 }
984 984
985 985
986 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) { 986 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) {
987 info()->MarkAsRequiresFrame();
987 return DefineAsRegister( 988 return DefineAsRegister(
988 new(zone()) LArgumentsLength(UseRegister(length->value()))); 989 new(zone()) LArgumentsLength(UseRegister(length->value())));
989 } 990 }
990 991
991 992
992 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) { 993 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) {
994 info()->MarkAsRequiresFrame();
993 return DefineAsRegister(new(zone()) LArgumentsElements); 995 return DefineAsRegister(new(zone()) LArgumentsElements);
994 } 996 }
995 997
996 998
997 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) { 999 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) {
998 LInstanceOf* result = 1000 LInstanceOf* result =
999 new(zone()) LInstanceOf(UseFixed(instr->left(), a0), 1001 new(zone()) LInstanceOf(UseFixed(instr->left(), a0),
1000 UseFixed(instr->right(), a1)); 1002 UseFixed(instr->right(), a1));
1001 return MarkAsCall(DefineFixed(result, v0), instr); 1003 return MarkAsCall(DefineFixed(result, v0), instr);
1002 } 1004 }
(...skipping 1317 matching lines...) Expand 10 before | Expand all | Expand 10 after
2320 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2322 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2321 // There are no real uses of the arguments object. 2323 // There are no real uses of the arguments object.
2322 // arguments.length and element access are supported directly on 2324 // arguments.length and element access are supported directly on
2323 // stack arguments, and any real arguments object use causes a bailout. 2325 // stack arguments, and any real arguments object use causes a bailout.
2324 // So this value is never used. 2326 // So this value is never used.
2325 return NULL; 2327 return NULL;
2326 } 2328 }
2327 2329
2328 2330
2329 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2331 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2332 info()->MarkAsRequiresFrame();
2330 LOperand* args = UseRegister(instr->arguments()); 2333 LOperand* args = UseRegister(instr->arguments());
2331 LOperand* length = UseTempRegister(instr->length()); 2334 LOperand* length = UseTempRegister(instr->length());
2332 LOperand* index = UseRegister(instr->index()); 2335 LOperand* index = UseRegister(instr->index());
2333 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index)); 2336 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index));
2334 } 2337 }
2335 2338
2336 2339
2337 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) { 2340 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) {
2338 LOperand* object = UseFixed(instr->value(), a0); 2341 LOperand* object = UseFixed(instr->value(), a0);
2339 LToFastProperties* result = new(zone()) LToFastProperties(object); 2342 LToFastProperties* result = new(zone()) LToFastProperties(object);
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
2469 2472
2470 2473
2471 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2474 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2472 LOperand* object = UseRegister(instr->object()); 2475 LOperand* object = UseRegister(instr->object());
2473 LOperand* index = UseRegister(instr->index()); 2476 LOperand* index = UseRegister(instr->index());
2474 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2477 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2475 } 2478 }
2476 2479
2477 2480
2478 } } // namespace v8::internal 2481 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698