Chromium Code Reviews Chromium Code Reviews
Issue
1436683002:
Making PageSerializer operate on single frames only. (Closed)
DescriptionOOPIFs: Making PageSerializer operate on single frames only.
This CL makes PageSerializer safe wrt OOPIFs, by making it operate on
single, local frames only. This CL moves iterating over all frames from
PageSerializer into 1) WebPageSerializer.cpp and 2) PageSerializerTest.cpp.
This is a preparatory step for a future CL that will need to move this
iteration from WebPageSerializer.cpp into the browser process (this
future CL will remove duplication of the iteration code between
WebPageSerializer.cpp and PageSerializerTest.cpp).
Changes made by this CL to WebPageSerializer.cpp use the more granular
MHTMLArchive methods introduced by crrev.com/1415463007 (these methods
allow generating snippets of MHTML for individual MHTML parts [i.e.
frames or resources] rather than for the whole page / view).
This in turn means that the non-granular MHTMLArchive::generateMHTMLData
method is no longer called from product code. This method has been
therefore removed from MHTMLArchive and inlined into the remaining test
code that still needed this functionality.
BUG=538766
Committed: https://crrev.com/6b9bf4d2319e2b36b54ac4663571a40bbfe06b94
Cr-Commit-Position: refs/heads/master@{#360631}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Rebasing... #Patch Set 3 : Addressed CR feedback from Daniel. #
Total comments: 8
Patch Set 4 : Rebasing... #Patch Set 5 : Addressed 2nd round of CR feedback from Daniel. #
Total comments: 2
Patch Set 6 : Const-ref params in methods of PageSerializer. #Patch Set 7 : Rebasing... #
Messages
Total messages: 27 (9 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
