Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143663004: FindBugs: Fix a synchronized method warning in HttpAuthDatabase.java. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

FindBugs: Fix a synchronized method warning in HttpAuthDatabase.java. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248914

Patch Set 1 #

Total comments: 1

Patch Set 2 : with lock var #

Patch Set 3 : update findbugs_known_bugs.txt #

Total comments: 2

Patch Set 4 : synchronize correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java View 1 2 3 3 chunks +14 lines, -10 lines 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Lei Zhang
6 years, 10 months ago (2014-01-31 18:51:23 UTC) #1
aurimas (slooooooooow)
https://codereview.chromium.org/143663004/diff/1/android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java File android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java (right): https://codereview.chromium.org/143663004/diff/1/android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java#newcode78 android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java:78: synchronized (this) { This will still synchronize on the ...
6 years, 10 months ago (2014-02-01 00:17:29 UTC) #2
Lei Zhang
Ok, see patch set 2.
6 years, 10 months ago (2014-02-01 05:06:47 UTC) #3
aurimas (slooooooooow)
LGTM +boliu for OWNERS review
6 years, 10 months ago (2014-02-02 18:13:57 UTC) #4
boliu
lgtm
6 years, 10 months ago (2014-02-02 18:31:33 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-03 04:30:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/143663004/110001
6 years, 10 months ago (2014-02-03 04:30:47 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 05:28:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255399
6 years, 10 months ago (2014-02-03 05:28:41 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 05:28:45 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 05:28:46 UTC) #11
boliu
https://codereview.chromium.org/143663004/diff/110001/android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java File android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java (right): https://codereview.chromium.org/143663004/diff/110001/android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java#newcode148 android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java:148: wait(); This needs to be mInitializedLock.wait() I think.
6 years, 10 months ago (2014-02-04 23:26:25 UTC) #12
Lei Zhang
https://codereview.chromium.org/143663004/diff/110001/android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java File android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java (right): https://codereview.chromium.org/143663004/diff/110001/android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java#newcode148 android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java:148: wait(); On 2014/02/04 23:26:25, boliu wrote: > This needs ...
6 years, 10 months ago (2014-02-05 00:50:39 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-05 00:51:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/143663004/420001
6 years, 10 months ago (2014-02-05 03:41:24 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:14:22 UTC) #16
Message was sent while issue was closed. 
Change committed as 248914

Powered by Google App Engine
This is Rietveld 408576698