Issue 14366039: Remove universal inclusion rule for browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14366039: Remove universal inclusion rule for browser/extensions/ (Closed)

Created:
7 years, 8 months ago by hshi1

Modified:
7 years, 8 months ago

Reviewers:
rkc, Nico

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, rkc

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove universal inclusion rule for browser/extensions/ This rule prevents conditional source file exclusion to work properly. BUG=175798 BUG=234701 TEST=CQ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195913

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	chrome/chrome_browser_extensions.gypi	View		4 chunks	+3 lines, -8 lines	0 comments	Download

Total messages: 5 (0 generated)

hshi1

Please take a look. I believe that the universal inclusion rule is unnecessary because all ...

7 years, 8 months ago (2013-04-23 18:21:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/14366039/10002

7 years, 8 months ago (2013-04-23 19:11:56 UTC) #4

hshi1

7 years, 8 months ago (2013-04-23 22:15:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r195913 (presubmit successful).