Places the unread count in the middle of web notification tray button.

Places the unread count in the middle of web notification tray button.

In the new design, we places the unread count of the notifications to the button.
If there are no unread notifications, we still use the existing dim icon.

Othewise, the count is put in the middle. "9+" is used if more than 9 unread
notifications.

BUG=189129
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195333

[somast, 2013-04-19 17:34:22]

On 2013/04/19 03:36:46, Jun Mukai wrote:

Jun, we should be using the existing lit icon (not dim) when there are no unread
notifications. We will be doing something similar on Windows (see
https://docs.google.com/a/google.com/file/d/0B4tKgpQN7CIgcExBWDNIN3FwWWc/edit)

[stevenjb, 2013-04-19 20:56:06]

lgtm

https://codereview.chromium.org/14366014/diff/1/ash/system/web_notification/w...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/14366014/diff/1/ash/system/web_notification/w...
ash/system/web_notification/web_notification_tray.cc:109:
IDR_AURA_UBER_TRAY_NOTIFY_BUTTON_INACTIVE_HOVER));
nit:align

[dewittj, 2013-04-19 21:34:31]

lgtm

https://codereview.chromium.org/14366014/diff/1/ash/system/web_notification/w...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/14366014/diff/1/ash/system/web_notification/w...
ash/system/web_notification/web_notification_tray.cc:55: const int
kUnreadLabelBottomOffset = 4;
Is this the font's descender height?  Will we want to auto-correct this if the
fonts change?  I ended up using a spritemap on Windows to ensure it looks nice..

[Jun Mukai, 2013-04-19 22:22:34]

https://codereview.chromium.org/14366014/diff/1/ash/system/web_notification/w...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/14366014/diff/1/ash/system/web_notification/w...
ash/system/web_notification/web_notification_tray.cc:55: const int
kUnreadLabelBottomOffset = 4;
On 2013/04/19 21:34:32, dewittj wrote:
> Is this the font's descender height?  Will we want to auto-correct this if the
> fonts change?  I ended up using a spritemap on Windows to ensure it looks
nice..

No, without this offset, the number is very close to the bottom line of the
button, doesn't look correctly aligned.

https://codereview.chromium.org/14366014/diff/1/ash/system/web_notification/w...
ash/system/web_notification/web_notification_tray.cc:109:
IDR_AURA_UBER_TRAY_NOTIFY_BUTTON_INACTIVE_HOVER));
On 2013/04/19 20:56:06, stevenjb (chromium) wrote:
> nit:align

Done.

[commit-bot: I haz the power, 2013-04-19 22:23:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/14366014/7001

[commit-bot: I haz the power, 2013-04-19 23:06:43]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Jun Mukai, 2013-04-19 23:18:30]

On 2013/04/19 23:06:43, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on mac.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Mac is irrelevant. dcommit manually.

[dewittj1, 2013-04-19 23:20:45]

On 2013/04/19 23:18:30, Jun Mukai wrote:
> On 2013/04/19 23:06:43, I haz the power (commit-bot) wrote:
> > Sorry for I got bad news for ya.
> > Compile failed with a clobber build on mac.
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
> > Your code is likely broken or HEAD is junk. Please ensure your
> > code is not broken then alert the build sheriffs.
> > Look at the try server FAQ for more details.
> 
> Mac is irrelevant. dcommit manually.

The commit that broke mac has since been reverted, so no worries.

[Jun Mukai, 2013-04-19 23:22:14]

Committed patchset #2 manually as r195333 (presubmit successful).