Issue 14366010: drive: Fix a bug where special directories are suggested from autocomplete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14366010: drive: Fix a bug where special directories are suggested from autocomplete (Closed)

Created:
7 years, 8 months ago by satorux1

Modified:
7 years, 8 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Fix a bug where special directories are suggested from autocomplete Special directories ("drive", "drive/root", and "drive/other") should not be suggested from autocomplete. Always exclude these directories in SearchMetadata() as it's unlikely for us to want these directories in results from SearchMetadata(). We can make it an option when neeed. BUG=232281 TEST=Open Drive in Files.app. Type "drive", "root", "other" in the search box, and confirm the special directories are not suggested. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195072

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/drive/search_metadata.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/search_metadata_unittest.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

7 years, 8 months ago (2013-04-19 03:32:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r195072 (presubmit successful).

Expand Messages | Collapse Messages