chrome/browser/extensions/extension_keybinding_apitest.cc - Issue 14366006: Disable CommandsApiTest.DontOverwriteSystemShortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_keybinding_apitest.cc

Issue 14366006: Disable CommandsApiTest.DontOverwriteSystemShortcuts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_keybinding_apitest.cc

diff --git a/chrome/browser/extensions/extension_keybinding_apitest.cc b/chrome/browser/extensions/extension_keybinding_apitest.cc

index cc7a6cb35b58d3f311c2651031ca5421764d3970..5e21db81a01098e151bc5af94b702bc77f897ef4 100644

--- a/chrome/browser/extensions/extension_keybinding_apitest.cc

+++ b/chrome/browser/extensions/extension_keybinding_apitest.cc

@@ -197,7 +197,8 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest, SynthesizedCommand) {

// This test validates that an extension cannot request a shortcut that is

// already in use by Chrome.

-IN_PROC_BROWSER_TEST_F(CommandsApiTest, DontOverwriteSystemShortcuts) {

+// Flaky, see http://crbug.com/233372.

+IN_PROC_BROWSER_TEST_F(CommandsApiTest, DISABLED_DontOverwriteSystemShortcuts) {

ASSERT_TRUE(test_server()->Start());

ASSERT_TRUE(RunExtensionTest("keybinding/dont_overwrite_system")) << message_;

« no previous file with comments | « no previous file | no next file » | no next file with comments »