Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1436583002: Revert of Remove setVoiceSearchSupported part of EmbeddedSearch SearchBox API. (Closed)

Created:
5 years, 1 month ago by robliao
Modified:
5 years, 1 month ago
Reviewers:
msw, samarth, oshima, Evan Stade
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, oshima+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, chromium-apps-reviews_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, tfarina, kmadhusu+watch_chromium.org, James Su, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove setVoiceSearchSupported part of EmbeddedSearch SearchBox API. (patchset #4 id:60001 of https://codereview.chromium.org/1428423002/ ) Reason for revert: ..\..\chrome\app\chrome_dll.rc(118) : error RC2104 : undefined keyword or key name: IDC_TOGGLE_SPEECH_INPUT Original issue's description: > Remove setVoiceSearchSupported part of EmbeddedSearch SearchBox API. > > also remove the mic search view from the location bar. The NTP "omnibox" still has voice search but that's unrelated. > > BUG=522168 > TBR=oshima@chromium.org > > Committed: https://crrev.com/e3168e1578dc4bbc928d86976a33db284ede2164 > Cr-Commit-Position: refs/heads/master@{#358641} TBR=samarth@chromium.org,msw@chromium.org,oshima@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522168 Committed: https://crrev.com/c3f9baf19272988820ae7bdf602578f9bf76a6ea Cr-Commit-Position: refs/heads/master@{#358651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -13 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/app/theme/default_100_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
A chrome/app/theme/material_100_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
A chrome/app/theme/material_200_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 6 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 8 chunks +22 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/location_bar/mic_search_decoration.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/location_bar/mic_search_decoration.mm View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.h View 5 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_unittest.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 5 chunks +53 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_model.h View 3 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_model.cc View 2 chunks +27 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/search_model_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/view_ids.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 7 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 12 chunks +58 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/searchbox_api.js View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 5 chunks +39 lines, -0 lines 0 comments Download
M chrome/test/data/instant_extended.html View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/test/data/instant_extended_ntp.html View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robliao
Created Revert of Remove setVoiceSearchSupported part of EmbeddedSearch SearchBox API.
5 years, 1 month ago (2015-11-09 21:18:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436583002/1
5 years, 1 month ago (2015-11-09 21:19:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 21:22:38 UTC) #3
robliao
This run includes the complete info: https://build.chromium.org/p/chromium/builders/Win/builds/37244
5 years, 1 month ago (2015-11-09 21:22:44 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 21:23:15 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3f9baf19272988820ae7bdf602578f9bf76a6ea
Cr-Commit-Position: refs/heads/master@{#358651}

Powered by Google App Engine
This is Rietveld 408576698