tools/gn/substitution_writer.cc - Issue 1436563003: Support spaces in Mac GN build output names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/substitution_writer.cc

Issue 1436563003: Support spaces in Mac GN build output names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/substitution_writer.cc

diff --git a/tools/gn/substitution_writer.cc b/tools/gn/substitution_writer.cc

index a642e478c98e373a6907d94ee2c73aa183108973..0351eb17f97d0d981ff01c94943204fb4b843249 100644

--- a/tools/gn/substitution_writer.cc

+++ b/tools/gn/substitution_writer.cc

@@ -422,6 +422,9 @@ bool SubstitutionWriter::GetTargetSubstitution(

*result = target->label().GetUserVisibleName(

!target->settings()->is_default());

break;

+ case SUBSTITUTION_LABEL_NAME:

+ *result = target->label().name();

+ break;

case SUBSTITUTION_ROOT_GEN_DIR:

SetDirOrDotWithNoSlash(

GetToolchainGenDirAsOutputFile(target->settings()).value(),

« no previous file with comments | « tools/gn/substitution_type.cc ('k') | tools/gn/substitution_writer_unittest.cc » ('j') | no next file with comments »