Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 1436563003: Support spaces in Mac GN build output names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/substitution_type.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.cc
diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc
index cfc207cf8cc04364fca851c4b70148d1cf80c26c..76413076685207938ec73c2bd9d192ae0efa8f16 100644
--- a/tools/gn/ninja_target_writer.cc
+++ b/tools/gn/ninja_target_writer.cc
@@ -103,6 +103,12 @@ void NinjaTargetWriter::WriteSharedVars(const SubstitutionBits& bits) {
written_anything = true;
}
+ // Target label name
+ if (bits.used[SUBSTITUTION_LABEL_NAME]) {
+ WriteEscapedSubstitution(SUBSTITUTION_LABEL_NAME);
+ written_anything = true;
+ }
+
// Root gen dir.
if (bits.used[SUBSTITUTION_ROOT_GEN_DIR]) {
WriteEscapedSubstitution(SUBSTITUTION_ROOT_GEN_DIR);
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/substitution_type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698