Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: tools/gn/function_toolchain.cc

Issue 1436563003: Support spaces in Mac GN build output names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <limits> 6 #include <limits>
7 7
8 #include "tools/gn/err.h" 8 #include "tools/gn/err.h"
9 #include "tools/gn/functions.h" 9 #include "tools/gn/functions.h"
10 #include "tools/gn/parse_tree.h" 10 #include "tools/gn/parse_tree.h"
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 " All paths are relative to the root build directory, which is the\n" 588 " All paths are relative to the root build directory, which is the\n"
589 " current directory for running all tools. These expansions are\n" 589 " current directory for running all tools. These expansions are\n"
590 " available to all tools:\n" 590 " available to all tools:\n"
591 "\n" 591 "\n"
592 " {{label}}\n" 592 " {{label}}\n"
593 " The label of the current target. This is typically used in the\n" 593 " The label of the current target. This is typically used in the\n"
594 " \"description\" field for link tools. The toolchain will be\n" 594 " \"description\" field for link tools. The toolchain will be\n"
595 " omitted from the label for targets in the default toolchain, and\n" 595 " omitted from the label for targets in the default toolchain, and\n"
596 " will be included for targets in other toolchains.\n" 596 " will be included for targets in other toolchains.\n"
597 "\n" 597 "\n"
598 " {{label_name}}\n"
599 " The short name of the label of the target. This is the part\n"
600 " after the colon. For \"//foo/bar:baz\" this will be \"baz\".\n"
601 " Unlike {{target_output_name}}, this is not affected by the\n"
602 " \"output_prefix\" in the tool or the \"output_name\" set\n"
603 " on the target.\n"
604 "\n"
598 " {{output}}\n" 605 " {{output}}\n"
599 " The relative path and name of the output(s) of the current\n" 606 " The relative path and name of the output(s) of the current\n"
600 " build step. If there is more than one output, this will expand\n" 607 " build step. If there is more than one output, this will expand\n"
601 " to a list of all of them.\n" 608 " to a list of all of them.\n"
602 " Example: \"out/base/my_file.o\"\n" 609 " Example: \"out/base/my_file.o\"\n"
603 "\n" 610 "\n"
604 " {{target_gen_dir}}\n" 611 " {{target_gen_dir}}\n"
605 " {{target_out_dir}}\n" 612 " {{target_out_dir}}\n"
606 " The directory of the generated file and output directories,\n" 613 " The directory of the generated file and output directories,\n"
607 " respectively, for the current target. There is no trailing\n" 614 " respectively, for the current target. There is no trailing\n"
608 " slash.\n" 615 " slash.\n"
609 " Example: \"out/base/test\"\n" 616 " Example: \"out/base/test\"\n"
610 "\n" 617 "\n"
611 " {{target_output_name}}\n" 618 " {{target_output_name}}\n"
612 " The short name of the current target with no path information,\n" 619 " The short name of the current target with no path information,\n"
613 " or the value of the \"output_name\" variable if one is specified\n" 620 " or the value of the \"output_name\" variable if one is specified\n"
614 " in the target. This will include the \"output_prefix\" if any.\n" 621 " in the target. This will include the \"output_prefix\" if any.\n"
622 " See also {{label_name}}.\n"
615 " Example: \"libfoo\" for the target named \"foo\" and an\n" 623 " Example: \"libfoo\" for the target named \"foo\" and an\n"
616 " output prefix for the linker tool of \"lib\".\n" 624 " output prefix for the linker tool of \"lib\".\n"
617 "\n" 625 "\n"
618 " Compiler tools have the notion of a single input and a single output,\n" 626 " Compiler tools have the notion of a single input and a single output,\n"
619 " along with a set of compiler-specific flags. The following expansions\n" 627 " along with a set of compiler-specific flags. The following expansions\n"
620 " are available:\n" 628 " are available:\n"
621 "\n" 629 "\n"
622 " {{asmflags}}\n" 630 " {{asmflags}}\n"
623 " {{cflags}}\n" 631 " {{cflags}}\n"
624 " {{cflags_c}}\n" 632 " {{cflags_c}}\n"
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 return Value(); 966 return Value();
959 967
960 Scope::KeyValueMap values; 968 Scope::KeyValueMap values;
961 block_scope.GetCurrentScopeValues(&values); 969 block_scope.GetCurrentScopeValues(&values);
962 toolchain->args() = values; 970 toolchain->args() = values;
963 971
964 return Value(); 972 return Value();
965 } 973 }
966 974
967 } // namespace functions 975 } // namespace functions
OLDNEW
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698