Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1436533003: android: Handle getViewSurface() failure gracefully. (Closed)

Created:
5 years, 1 month ago by no sievers
Modified:
5 years, 1 month ago
Reviewers:
reveman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Handle getViewSurface() failure gracefully. This might occur during browser shutdown. Also log some more specific errors. BUG=529233 Committed: https://crrev.com/705fedd2eac735f553b8c8fafbf91c25080efce5 Cr-Commit-Position: refs/heads/master@{#359018}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/common/gpu/image_transport_surface_android.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 2 chunks +5 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
no sievers
ptal https://codereview.chromium.org/1436533003/diff/1/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java File content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java (right): https://codereview.chromium.org/1436533003/diff/1/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java#newcode44 content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:44: private static final String TAG = "cr.ChildProcLauncher"; presubmit ...
5 years, 1 month ago (2015-11-11 01:02:30 UTC) #3
reveman
lgtm
5 years, 1 month ago (2015-11-11 01:09:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436533003/1
5 years, 1 month ago (2015-11-11 01:22:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 02:11:33 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 02:12:38 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/705fedd2eac735f553b8c8fafbf91c25080efce5
Cr-Commit-Position: refs/heads/master@{#359018}

Powered by Google App Engine
This is Rietveld 408576698