Issue 143653014: Fix dragging onto shortcuts in the volume list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143653014: Fix dragging onto shortcuts in the volume list. (Closed)

Created:
6 years, 10 months ago by mtomasz

Modified:
6 years, 10 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix dragging onto shortcuts in the volume list. The previous patch had a bug. Instead of modelItem.entry, entry was used, which was always undefined. TEST=Tested manually. BUG=337575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247581

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/file_manager/foreground/js/file_transfer_controller.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hirono

On 2014/01/27 08:43:09, mtomasz wrote: > @hirono: PTAL. Thanks. lgtm! Sorry for missed it in ...

6 years, 10 months ago (2014-01-27 10:59:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/143653014/1

6 years, 10 months ago (2014-01-27 12:05:48 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=195083

6 years, 10 months ago (2014-01-27 13:40:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/143653014/1

6 years, 10 months ago (2014-01-29 00:43:30 UTC) #5

Message was sent while issue was closed.

Change committed as 247581

Expand Messages | Collapse Messages