Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Issue 143653014: Fix dragging onto shortcuts in the volume list. (Closed)

Created:
6 years, 10 months ago by mtomasz
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix dragging onto shortcuts in the volume list. The previous patch had a bug. Instead of modelItem.entry, entry was used, which was always undefined. TEST=Tested manually. BUG=337575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 10 months ago (2014-01-27 08:43:09 UTC) #1
hirono
On 2014/01/27 08:43:09, mtomasz wrote: > @hirono: PTAL. Thanks. lgtm! Sorry for missed it in ...
6 years, 10 months ago (2014-01-27 10:59:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/143653014/1
6 years, 10 months ago (2014-01-27 12:05:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=195083
6 years, 10 months ago (2014-01-27 13:40:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/143653014/1
6 years, 10 months ago (2014-01-29 00:43:30 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 01:50:57 UTC) #6
Message was sent while issue was closed.
Change committed as 247581

Powered by Google App Engine
This is Rietveld 408576698