Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: gm/gm_json.py

Issue 143653006: new tool: download all GM images for a given builder, ready for skdiff (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: final touches Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/rebaseline_server/download_actuals.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gm_json.py
diff --git a/gm/gm_json.py b/gm/gm_json.py
index 7cd4455f797371acf14c9fe05f576935f4b137da..1aac6632f5674b0adec9f7c915c82d2837ec3308 100644
--- a/gm/gm_json.py
+++ b/gm/gm_json.py
@@ -104,6 +104,8 @@ def CreateGmActualUrl(test_name, hash_type, hash_digest,
hash_digest: the hash digest of the image to retrieve
gm_actuals_root_url: root url where actual images are stored
"""
+ # TODO(epoger): Maybe use url_or_path.join() so that, for testing, this can
+ # return either a URL or a local filepath?
return '%s/%s/%s/%s.png' % (gm_actuals_root_url, hash_type, test_name,
hash_digest)
« no previous file with comments | « no previous file | gm/rebaseline_server/download_actuals.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698