Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1436513002: SkPx: use namespaces as namespaces (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPx: use namespaces as namespaces This is a pure refactor. No behavior change. I'm just getting tired of typing out the names... BUG=skia:4117 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/b4df8b73d796c601fd7b046dcc68aaab67f0fc33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -44 lines) Patch
M src/opts/SkPx_neon.h View 7 chunks +17 lines, -12 lines 0 comments Download
M src/opts/SkPx_none.h View 4 chunks +23 lines, -18 lines 0 comments Download
M src/opts/SkPx_sse.h View 4 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mtklein
5 years, 1 month ago (2015-11-09 16:43:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436513002/1
5 years, 1 month ago (2015-11-09 16:43:40 UTC) #6
mtklein_C
Er, from me@chromium.org this time.
5 years, 1 month ago (2015-11-09 16:44:01 UTC) #8
msarett
lgtm
5 years, 1 month ago (2015-11-09 16:50:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436513002/1
5 years, 1 month ago (2015-11-09 16:51:01 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 16:55:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b4df8b73d796c601fd7b046dcc68aaab67f0fc33

Powered by Google App Engine
This is Rietveld 408576698