Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc

Issue 14365019: Break dependencies preventing move of test_server down to net. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/oobe_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc
diff --git a/chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc b/chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc
index 49a36dda556fa49eaa442936852b9abbc624079f..126c83064d32aca3697a065c3e20d3c1286cebdc 100644
--- a/chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc
+++ b/chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc
@@ -84,7 +84,10 @@ class GDataContactsServiceTest : public testing::Test {
content::BrowserThread::GetMessageLoopProxyForThread(
content::BrowserThread::IO));
- test_server_.reset(new google_apis::test_server::HttpServer());
+ test_server_.reset(
+ new google_apis::test_server::HttpServer(
+ content::BrowserThread::GetMessageLoopProxyForThread(
+ content::BrowserThread::IO)));
ASSERT_TRUE(test_server_->InitializeAndWaitUntilReady());
test_server_->RegisterRequestHandler(
base::Bind(&GDataContactsServiceTest::HandleDownloadRequest,
@@ -105,7 +108,7 @@ class GDataContactsServiceTest : public testing::Test {
}
virtual void TearDown() OVERRIDE {
- test_server_->ShutdownAndWaitUntilComplete();
+ EXPECT_TRUE(test_server_->ShutdownAndWaitUntilComplete());
test_server_.reset();
request_context_getter_ = NULL;
service_.reset();
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/oobe_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698