Issue 14365014: Switch elements access to use IfBuilder instead of CheckBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14365014: Switch elements access to use IfBuilder instead of CheckBuilder. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger

Modified:
7 years, 8 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Switch elements access to use IfBuilder instead of CheckBuilder. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14360

Patch Set 2 : Addressed comments by Daniel Clifford. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	src/hydrogen.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	src/hydrogen.cc	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danno

https://codereview.chromium.org/14365014/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/14365014/diff/1/src/hydrogen.cc#newcode1317 src/hydrogen.cc:1317: HValue* bounds_check = bounds_checker.AndIfCompare( This logic isn't quite the ...

7 years, 8 months ago (2013-04-19 14:25:47 UTC) #2

Michael Starzinger

7 years, 8 months ago (2013-04-19 16:06:53 UTC) #3

Michael Starzinger

7 years, 8 months ago (2013-04-19 16:21:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14360 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14365014: Switch elements access to use IfBuilder instead of CheckBuilder. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Daniel Clifford. #

Messages