Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 14365011: OS::MemMove/OS::MemCopy: Don't call through to generated code when size == 0 to avoid prefetching i… (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

OS::MemMove/OS::MemCopy: Don't call through to generated code when size == 0 to avoid prefetching invalid memory BUG=chromium:233500 Committed: http://code.google.com/p/v8/source/detail?r=14361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/ia32/codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 8 months ago (2013-04-19 09:34:31 UTC) #1
Michael Starzinger
LGTM.
7 years, 8 months ago (2013-04-19 12:39:24 UTC) #2
Jakob Kummerow
7 years, 8 months ago (2013-04-19 16:38:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14361 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698