Add a way to query a cookie store whether any cookies exist for a given

Add a way to query a cookie store whether any cookies exist for a given
ETLD+1.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195258

[tburkard, 2013-04-19 18:05:22]

Hey Erik,

it'd be great if you could get to this today. If not, can you tell me an
approximate ETA?

Thanks, and have a good weekend.

[erikwright (departed), 2013-04-19 18:15:34]

On 2013/04/19 18:05:22, tburkard wrote:
> Hey Erik,
> 
> it'd be great if you could get to this today. If not, can you tell me an
> approximate ETA?
> 
> Thanks, and have a good weekend.

Looks fine, but I think your caller could have a pointer to the CookieMonster
instead of the CookieStore? This code can't run with an alternative cookie store
implementation, IIUC because the delegate support is in the CM.

In which case we avoid extending the base API.

In any case, I'm not even sure if it would be possible to implement this API on
other CS implementations (such as Bling's).

[tburkard, 2013-04-19 18:25:59]

Thanks, Erik. I was actually going to access the cookie store the way it is
done in BrowsingDataRemover::ClearCookiesOnIOThread. URLRequestContext only
supports CookieStore, but not CookieMonster.

Oh.. I guess there is a GetCookieMonster method, so I can use that to get
the cookie monster?

That should work. Let me update the change. Thanks.

[tburkard, 2013-04-19 18:34:49]

Updated the change, please take a look.

Thanks.

[erikwright (departed), 2013-04-19 18:37:20]

Sorry, I thought that this is being done from within a delegate that is
attached to the cookie monster. So can't you pass a raw pointer to the
cookie monster to your delegate's constructor?


On Fri, Apr 19, 2013 at 2:25 PM, Timo Burkard <tburkard@chromium.org> wrote:

> Thanks, Erik. I was actually going to access the cookie store the way it
> is done in BrowsingDataRemover::ClearCookiesOnIOThread. URLRequestContext
> only supports CookieStore, but not CookieMonster.
>
> Oh.. I guess there is a GetCookieMonster method, so I can use that to get
> the cookie monster?
>
> That should work. Let me update the change. Thanks.
>

[tburkard, 2013-04-19 19:23:43]

I figured out how to do it -- when I have a CookieStore object, I can call
GetCookieMonster. So just making the change in CookieMonster like I most
recently changed the CL to is sufficient.

Does the most recent version look good to you?

Thanks.

[erikwright (departed), 2013-04-19 19:28:34]

I'd prefer you avoid calling GetCookieMonster if possible, that function
should be marked deprecated.


On Fri, Apr 19, 2013 at 3:23 PM, Timo Burkard <tburkard@chromium.org> wrote:

> I figured out how to do it -- when I have a CookieStore object, I can call
> GetCookieMonster. So just making the change in CookieMonster like I most
> recently changed the CL to is sufficient.
>
> Does the most recent version look good to you?
>
> Thanks.
>

[erikwright (departed), 2013-04-19 19:29:03]

LGTM, assuming it does what you need.

[tburkard, 2013-04-19 19:50:08]

Committed patchset #6 manually as r195258.