Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1436493002: [builtins] Introduce specialized Call/CallFunction builtins. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce specialized Call/CallFunction builtins. Introduce receiver conversion mode specialization for the Call and CallFunction builtins, so we can specialize the builtin functionality (actually an optimization only) based on static information from the callsite (this is basically a superset of the optimizations that were available with the CallFunctionStub and CallICStub, except that these optimizations are correct now). This fixes a regression introduced by the removal of CallFunctionStub, for programs that call a lot. R=yangguo@chromium.org BUG=chromium:552244 LOG=n Committed: https://crrev.com/7c3396d01c7181b22b3dc4cdc38cd4b288f7d9c3 Cr-Commit-Position: refs/heads/master@{#31871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -460 lines) Patch
M src/arm/builtins-arm.cc View 5 chunks +60 lines, -52 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 4 chunks +62 lines, -54 lines 0 comments Download
M src/builtins.h View 3 chunks +36 lines, -4 lines 0 comments Download
M src/builtins.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M src/code-factory.h View 2 chunks +9 lines, -4 lines 0 comments Download
M src/code-factory.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-operator.h View 1 chunk +1 line, -12 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 6 chunks +13 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 7 chunks +13 lines, -7 lines 0 comments Download
M src/globals.h View 1 chunk +25 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +62 lines, -55 lines 0 comments Download
M src/ic/ic.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/ic/ic-state.h View 1 chunk +14 lines, -5 lines 0 comments Download
M src/ic/ic-state.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/mips/builtins-mips.cc View 4 chunks +62 lines, -56 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 4 chunks +62 lines, -56 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +68 lines, -54 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-09 08:25:21 UTC) #1
Benedikt Meurer
Hey Yang, Here's the patch that introduces specialization (with ConvertReceiverMode) for Call/CallFunction builtins, that I ...
5 years, 1 month ago (2015-11-09 08:27:18 UTC) #2
Yang
lgtm
5 years, 1 month ago (2015-11-09 08:45:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436493002/1
5 years, 1 month ago (2015-11-09 08:46:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 08:48:05 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 08:48:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c3396d01c7181b22b3dc4cdc38cd4b288f7d9c3
Cr-Commit-Position: refs/heads/master@{#31871}

Powered by Google App Engine
This is Rietveld 408576698