Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1436473002: postmortem: add representation kinds, masks, shift (Closed)

Created:
5 years, 1 month ago by fedor.indutny
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Committed: https://crrev.com/68e89fbb0aabffab7607b21de75ecf62e1584283 Cr-Commit-Position: refs/heads/master@{#31947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M tools/gen-postmortem-metadata.py View 5 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
fedor.indutny
5 years, 1 month ago (2015-11-08 02:06:57 UTC) #1
fedor.indutny
Sorry, first message was badly formatted, and missed reviewers. Thanks!
5 years, 1 month ago (2015-11-08 02:07:51 UTC) #5
Michael Achenbach
Please find a better owner for review... +jkummerow@chromium.org
5 years, 1 month ago (2015-11-09 10:28:43 UTC) #7
Jakob Kummerow
Michael: there are no appropriate reviewers for gen-postmortem-metadata.py. Your rubberstamp is as good as mine. ...
5 years, 1 month ago (2015-11-11 09:32:09 UTC) #8
fedor.indutny
Thank you!
5 years, 1 month ago (2015-11-11 18:52:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436473002/1
5 years, 1 month ago (2015-11-11 18:52:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 19:13:50 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68e89fbb0aabffab7607b21de75ecf62e1584283
Cr-Commit-Position: refs/heads/master@{#31947}

Powered by Google App Engine
This is Rietveld 408576698