Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1436433002: Issue 24751. Report a compile time error when @static_field is used with arguments. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 24751. Report a compile time error when @static_field is used with arguments. @static_field(args) should be evaluated, but it cannot be, so it's a compile time error. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/24751 Committed: https://github.com/dart-lang/sdk/commit/574cef9ee702581cab3b8e915fd7927ec947fe27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-06 20:47:01 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-06 21:01:03 UTC) #2
scheglov
5 years, 1 month ago (2015-11-06 21:04:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
574cef9ee702581cab3b8e915fd7927ec947fe27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698