Issue 14364010: Lithium: avoid registers for constants when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14364010: Lithium: avoid registers for constants when possible. (Closed)

Created:
7 years, 8 months ago by mvstanton

Modified:
7 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Lithium: avoid registers for constants when possible. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14460

Patch Set 2 : New patch because diffs seem broken #

Patch Set 3 : Code review updates #

Total comments: 1

Patch Set 4 : Last comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -64 lines)			Patch
M	src/arm/lithium-arm.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	1 chunk	+12 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2	5 chunks	+14 lines, -27 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3	1 chunk	+11 lines, -4 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2	5 chunks	+14 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Toon, here is the change we discussed. As noted, it reverts a portion of ...

7 years, 8 months ago (2013-04-26 13:05:05 UTC) #1

Toon Verwaest

lgtm with last nit. https://codereview.chromium.org/14364010/diff/7001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/14364010/diff/7001/src/ia32/lithium-codegen-ia32.cc#newcode6033 src/ia32/lithium-codegen-ia32.cc:6033: __ mov(result, 0); Use Smi::FromInt(0) ...

7 years, 8 months ago (2013-04-26 13:59:19 UTC) #2