| Index: src/ia32/lithium-ia32.cc
|
| diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc
|
| index 2e8ca36bce995af96ce58ad1cf965471ac3b47c5..b4b44521cd0c0a4dd3227a455b3683f0b4b6f2fa 100644
|
| --- a/src/ia32/lithium-ia32.cc
|
| +++ b/src/ia32/lithium-ia32.cc
|
| @@ -2072,16 +2072,6 @@ LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
|
| }
|
|
|
|
|
| -LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
|
| - LOperand* context = UseFixed(instr->context(), esi);
|
| - LOperand* global_object = UseFixed(instr->global_object(), edx);
|
| - LOperand* value = UseFixed(instr->value(), eax);
|
| - LStoreGlobalGeneric* result =
|
| - new(zone()) LStoreGlobalGeneric(context, global_object, value);
|
| - return MarkAsCall(result, instr);
|
| -}
|
| -
|
| -
|
| LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
|
| LOperand* context = UseRegisterAtStart(instr->value());
|
| LInstruction* result =
|
| @@ -2153,19 +2143,17 @@ LInstruction* LChunkBuilder::DoLoadKeyed(HLoadKeyed* instr) {
|
| : UseRegisterOrConstantAtStart(instr->key());
|
| LLoadKeyed* result = NULL;
|
|
|
| - if (!instr->is_external()) {
|
| + if (!instr->is_typed_elements()) {
|
| LOperand* obj = UseRegisterAtStart(instr->elements());
|
| result = new(zone()) LLoadKeyed(obj, key);
|
| } else {
|
| ASSERT(
|
| (instr->representation().IsInteger32() &&
|
| - (elements_kind != EXTERNAL_FLOAT_ELEMENTS) &&
|
| - (elements_kind != EXTERNAL_DOUBLE_ELEMENTS)) ||
|
| + !(IsDoubleOrFloatElementsKind(instr->elements_kind()))) ||
|
| (instr->representation().IsDouble() &&
|
| - ((elements_kind == EXTERNAL_FLOAT_ELEMENTS) ||
|
| - (elements_kind == EXTERNAL_DOUBLE_ELEMENTS))));
|
| - LOperand* external_pointer = UseRegister(instr->elements());
|
| - result = new(zone()) LLoadKeyed(external_pointer, key);
|
| + (IsDoubleOrFloatElementsKind(instr->elements_kind()))));
|
| + LOperand* backing_store = UseRegister(instr->elements());
|
| + result = new(zone()) LLoadKeyed(backing_store, key);
|
| }
|
|
|
| DefineAsRegister(result);
|
| @@ -2195,7 +2183,10 @@ LOperand* LChunkBuilder::GetStoreKeyedValueOperand(HStoreKeyed* instr) {
|
| bool val_is_fixed_register =
|
| elements_kind == EXTERNAL_BYTE_ELEMENTS ||
|
| elements_kind == EXTERNAL_UNSIGNED_BYTE_ELEMENTS ||
|
| - elements_kind == EXTERNAL_PIXEL_ELEMENTS;
|
| + elements_kind == EXTERNAL_PIXEL_ELEMENTS ||
|
| + elements_kind == UINT8_ELEMENTS ||
|
| + elements_kind == INT8_ELEMENTS ||
|
| + elements_kind == UINT8_CLAMPED_ELEMENTS;
|
| if (val_is_fixed_register) {
|
| return UseFixed(instr->value(), eax);
|
| }
|
| @@ -2210,7 +2201,7 @@ LOperand* LChunkBuilder::GetStoreKeyedValueOperand(HStoreKeyed* instr) {
|
|
|
|
|
| LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
|
| - if (!instr->is_external()) {
|
| + if (!instr->is_typed_elements()) {
|
| ASSERT(instr->elements()->representation().IsTagged());
|
| ASSERT(instr->key()->representation().IsInteger32() ||
|
| instr->key()->representation().IsSmi());
|
| @@ -2242,23 +2233,22 @@ LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
|
| ElementsKind elements_kind = instr->elements_kind();
|
| ASSERT(
|
| (instr->value()->representation().IsInteger32() &&
|
| - (elements_kind != EXTERNAL_FLOAT_ELEMENTS) &&
|
| - (elements_kind != EXTERNAL_DOUBLE_ELEMENTS)) ||
|
| + !IsDoubleOrFloatElementsKind(elements_kind)) ||
|
| (instr->value()->representation().IsDouble() &&
|
| - ((elements_kind == EXTERNAL_FLOAT_ELEMENTS) ||
|
| - (elements_kind == EXTERNAL_DOUBLE_ELEMENTS))));
|
| - ASSERT(instr->elements()->representation().IsExternal());
|
| + IsDoubleOrFloatElementsKind(elements_kind)));
|
| + ASSERT((instr->is_fixed_typed_array() &&
|
| + instr->elements()->representation().IsTagged()) ||
|
| + (instr->is_external() &&
|
| + instr->elements()->representation().IsExternal()));
|
|
|
| - LOperand* external_pointer = UseRegister(instr->elements());
|
| + LOperand* backing_store = UseRegister(instr->elements());
|
| LOperand* val = GetStoreKeyedValueOperand(instr);
|
| bool clobbers_key = ExternalArrayOpRequiresTemp(
|
| instr->key()->representation(), elements_kind);
|
| LOperand* key = clobbers_key
|
| ? UseTempRegister(instr->key())
|
| : UseRegisterOrConstantAtStart(instr->key());
|
| - return new(zone()) LStoreKeyed(external_pointer,
|
| - key,
|
| - val);
|
| + return new(zone()) LStoreKeyed(backing_store, key, val);
|
| }
|
|
|
|
|
| @@ -2388,12 +2378,8 @@ LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
|
|
|
| LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
|
| LOperand* context = UseFixed(instr->context(), esi);
|
| - LOperand* left = FLAG_new_string_add
|
| - ? UseFixed(instr->left(), edx)
|
| - : UseOrConstantAtStart(instr->left());
|
| - LOperand* right = FLAG_new_string_add
|
| - ? UseFixed(instr->right(), eax)
|
| - : UseOrConstantAtStart(instr->right());
|
| + LOperand* left = UseFixed(instr->left(), edx);
|
| + LOperand* right = UseFixed(instr->right(), eax);
|
| LStringAdd* string_add = new(zone()) LStringAdd(context, left, right);
|
| return MarkAsCall(DefineFixed(string_add, eax), instr);
|
| }
|
|
|