Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1436283002: Add support for jslint and cleanup core JavaScript files (Closed)

Created:
5 years, 1 month ago by Sam Clegg
Modified:
5 years, 1 month ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com, Sam Clegg, gdeepti, binji
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Add support for jslint and cleanup core JavaScript files Many warning are suppressed at this point. Committed: https://chromium.googlesource.com/external/naclports/+/f77561bb5fab9b18f27ec97e07d79a0f92a9533d

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -353 lines) Patch
A .jslintrc View 1 chunk +15 lines, -0 lines 0 comments Download
M Makefile View 1 4 chunks +10 lines, -5 lines 0 comments Download
M build_tools/naclprocess.js View 50 chunks +312 lines, -298 lines 0 comments Download
M build_tools/naclterm.js View 16 chunks +43 lines, -38 lines 0 comments Download
M package.json View 1 chunk +2 lines, -1 line 0 comments Download
M ports/gdb/background.js View 3 chunks +6 lines, -3 lines 0 comments Download
M ports/libgit2-demo/libgit2.js View 1 chunk +4 lines, -3 lines 0 comments Download
M ports/lua/lua.js View 1 chunk +2 lines, -1 line 0 comments Download
M ports/quakespasm/quakespasm.js View 1 chunk +2 lines, -1 line 0 comments Download
M ports/vim/background.js View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436283002/1
5 years, 1 month ago (2015-11-12 20:18:59 UTC) #2
Sam Clegg
5 years, 1 month ago (2015-11-12 20:23:42 UTC) #4
bradn
lgtm
5 years, 1 month ago (2015-11-13 18:01:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436283002/20001
5 years, 1 month ago (2015-11-13 18:01:43 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 22:25:43 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/naclports/+/f77561bb5fab9b18f27ec9...

Powered by Google App Engine
This is Rietveld 408576698