chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 1436273002: Send safe browsing ThreatDetails to track download CTR when user tries to recover blocked downloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 1436273002: Send safe browsing ThreatDetails to track download CTR when user tries to recover blocked downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove extra file Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_danger_prompt.cc ('K') | « chrome/browser/download/download_danger_prompt_browsertest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.h » ('j') | chrome/browser/ui/views/download/download_danger_prompt_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index df3396b7779706fb68558b4841a03d527d004836..63eb6dd7a36196175d7a23271fc9df15dc7182e0 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -4040,7 +4040,8 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,

// without a WebContents.

void OnDangerPromptCreated(DownloadDangerPrompt* prompt) {

- prompt->InvokeActionForTesting(DownloadDangerPrompt::ACCEPT);

+ GURL unused_url = GURL::EmptyGURL();

msw 2015/11/17 01:17:38 nit: can you just inline the default ctor below? i

Jialiu Lin 2015/11/17 02:05:50 Done.

+ prompt->InvokeActionForTesting(DownloadDangerPrompt::ACCEPT, unused_url);

}

#if defined(OS_MACOSX)