Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Side by Side Diff: chrome/browser/download/download_danger_prompt.h

Issue 1436273002: Send safe browsing ThreatDetails to track download CTR when user tries to recover blocked downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing asanka and Lei's comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_ 5 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_
6 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_ 6 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 9
10 class GURL;
11
10 namespace content { 12 namespace content {
11 class DownloadItem; 13 class DownloadItem;
12 class WebContents; 14 class WebContents;
13 } 15 }
14 16
15 // Prompts the user for whether to Keep a dangerous DownloadItem using native 17 // Prompts the user for whether to Keep a dangerous DownloadItem using native
16 // UI. This prompt is invoked by the DownloadsDOMHandler when the user wants to 18 // UI. This prompt is invoked by the DownloadsDOMHandler when the user wants to
17 // accept a dangerous download. Having a native dialog intervene during the this 19 // accept a dangerous download. Having a native dialog intervene during the this
18 // workflow means that the chrome://downloads page no longer has the privilege 20 // workflow means that the chrome://downloads page no longer has the privilege
19 // to accept a dangerous download from script without user intervention. This 21 // to accept a dangerous download from script without user intervention. This
(...skipping 10 matching lines...) Expand all
30 typedef base::Callback<void(Action)> OnDone; 32 typedef base::Callback<void(Action)> OnDone;
31 33
32 // Return a new self-deleting DownloadDangerPrompt. |accepted| or |canceled| 34 // Return a new self-deleting DownloadDangerPrompt. |accepted| or |canceled|
33 // will be run when the the respective action is invoked. |canceled| may also 35 // will be run when the the respective action is invoked. |canceled| may also
34 // be called when |item| is either no longer dangerous or no longer in 36 // be called when |item| is either no longer dangerous or no longer in
35 // progress, or if the tab corresponding to |web_contents| is 37 // progress, or if the tab corresponding to |web_contents| is
36 // closing. The returned DownloadDangerPrompt* is only used for testing. The 38 // closing. The returned DownloadDangerPrompt* is only used for testing. The
37 // caller does not own the object and receive no guarantees about lifetime. 39 // caller does not own the object and receive no guarantees about lifetime.
38 // If |show_context|, then the prompt message will contain some information 40 // If |show_context|, then the prompt message will contain some information
39 // about the download and its danger; otherwise it won't. 41 // about the download and its danger; otherwise it won't.
40 static DownloadDangerPrompt* Create( 42 static DownloadDangerPrompt* Create(content::DownloadItem* item,
41 content::DownloadItem* item, 43 content::WebContents* web_contents,
42 content::WebContents* web_contents, 44 bool show_context,
43 bool show_context, 45 const OnDone& done);
44 const OnDone& done);
45 46
46 // Only to be used by tests. Subclasses must override to manually call the 47 // Only to be used by tests. Subclasses must override to manually call the
47 // respective button click handler. 48 // respective button click handler.
48 virtual void InvokeActionForTesting(Action action) = 0; 49 virtual void InvokeActionForTesting(Action action) = 0;
50
51 protected:
52 // Sends download recovery report to safe browsing backend.
53 // Since it only records download url (DownloadItem::GetURL()) and user's
54 // action (click through or not), it isn't gated by user's extended reporting
55 // preference (i.e. prefs::kSafeBrowsingExtendedReportingEnabled). We
56 // should not put any extra information in this report.
57 static void SendSafeBrowsingDownloadRecoveryReport(bool did_proceed,
58 const GURL& url);
49 }; 59 };
50 60
51 #endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_ 61 #endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698