sdk/lib/_internal/js_runtime/lib/js_helper.dart - Issue 1436263002: dart2js: Forbid # placeholders in JS function bodies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/js_runtime/lib/js_helper.dart

Issue 1436263002: dart2js: Forbid # placeholders in JS function bodies. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/js_runtime/lib/js_helper.dart

diff --git a/sdk/lib/_internal/js_runtime/lib/js_helper.dart b/sdk/lib/_internal/js_runtime/lib/js_helper.dart

index 20ac448df5fd9988f1c7e5cc0d168ee7e502a7ee..fdc1ee23e65d7129262b1de1dbd330773de1ab8e 100644

--- a/sdk/lib/_internal/js_runtime/lib/js_helper.dart

+++ b/sdk/lib/_internal/js_runtime/lib/js_helper.dart

@@ -2570,9 +2570,9 @@ abstract class Closure implements Function {

// captured variable `functionType` isn't reused.

signatureFunction =

JS('',

- '''(function(t) {

- return function(){ return #(t); };

- })(#)''',

+ '''(function(getType, t) {

+ return function(){ return getType(t); };

+ })(#, #)''',

RAW_DART_FUNCTION_REF(getType),

functionType);

} else if (!isStatic