pkg/compiler/lib/src/ssa/builder.dart - Issue 1436263002: dart2js: Forbid # placeholders in JS function bodies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1436263002: dart2js: Forbid # placeholders in JS function bodies. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index 2eae9e85caa2ddf9194ca3cc6c7457a4a3017203..0945568cfec8ca52f74c4eecf1ca669123a40266 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -4154,6 +4154,10 @@ class SsaBuilder extends ast.Visitor

return;

}

+ if (native.HasCapturedPlaceholders.check(nativeBehavior.codeTemplate.ast)) {

+ reporter.reportErrorMessage(node, MessageKind.JS_PLACEHOLDER_CAPTURE);

+ }

TypeMask ssaType =

TypeMaskFactory.fromNativeBehavior(nativeBehavior, compiler);